[Webkit-unassigned] [Bug 68162] [chromium]The focus of an input field inside an Iframe doesn't get cleared even though clearFocusedNode is called.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68162


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107608|review?                     |review+
               Flag|                            |




--- Comment #5 from Adam Barth <abarth at webkit.org>  2011-09-16 10:46:05 PST ---
(From update of attachment 107608)
View in context: https://bugs.webkit.org/attachment.cgi?id=107608&action=review

> Source/WebKit/chromium/tests/WebFrameTest.cpp:239
> +class TestWebViewClient : public WebViewClient { };

I'm not 100% clear why we need this class.  Can't we just use WebViewClient directly?

> Source/WebKit/chromium/ChangeLog:7
> +        [chromium]The focus of an input field inside an Iframe doesn't get cleared even though clearFocusedNode is called.
> +        https://bugs.webkit.org/show_bug.cgi?id=68162
> +
> +        Reviewed by NOBODY (OOPS!).
> +

In the future, it would be better to add more explanation to the ChangeLog entry about why you're making this change.  It's not just a huge deal for this patch, but it's a good habit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.