[Webkit-unassigned] [Bug 67952] Ask for audio hardware buffer size instead of using hardwired constants.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67952





--- Comment #17 from Raymond Toy <rtoy at chromium.org>  2011-09-16 10:02:12 PST ---
(From update of attachment 107400)
View in context: https://bugs.webkit.org/attachment.cgi?id=107400&action=review

>> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:72
>> +    ASSERT(m_callbackBufferSize <= maximumCallbackBufferSize);
> 
> Is asserting really the best behavior in this case, rather than for example clamping to the maximum callback buffer size?

Good question.  This was suggested by Chris in an earlier comment (#7).

This also begs the question if we should check for a minimum too.  I think ALSA can actually return a value as low as 1, which would be way too small for us.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.