[Webkit-unassigned] [Bug 68231] [EFL] Revert pointer operator coding style in ewk_view
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 16 01:24:52 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=68231
Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|webkit-unassigned at lists.web |gyuyoung.kim at samsung.com
|kit.org |
Attachment #107622| |review?, commit-queue?
Flag| |
--- Comment #1 from Gyuyoung Kim <gyuyoung.kim at samsung.com> 2011-09-16 01:24:51 PST ---
Created an attachment (id=107622)
--> (https://bugs.webkit.org/attachment.cgi?id=107622&action=review)
Patch for ewk_view.cpp
I adjust webkit rule into ewk_view.cpp first.
However, I'm not sure whether we should adjust this rule into ewk_view.h as well. Because, ewk_view.h is public header, which is included by C application. In addition, pointer operator placement of public header differs from .cpp fliles in GTK port.
For example, in webkit_web_view_set_settings function case,
- webkitwebview.h
WEBKIT_API void webkit_web_view_set_settings(WebKitWebView *webView, WebKitWebSettings *settings);
- webkitwebview.cpp
void webkit_web_view_set_settings(WebKitWebView* webView, WebKitWebSettings* webSettings)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list