[Webkit-unassigned] [Bug 67823] [NRWT] Provides a simple LRU cache class in Python.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67823





--- Comment #12 from Hayato Ito <hayato at chromium.org>  2011-09-15 23:04:23 PST ---
(From update of attachment 107604)
Thank you for updating the patch! I gave you one comment!

View in context: https://bugs.webkit.org/attachment.cgi?id=107604&action=review

> Tools/Scripts/webkitpy/common/lru_cache.py:60
> +        if key in self._dict:

I think L60-61 lines should move at the beginning of this function.
If self._dict has one item and L61 deletes that item, self._first becomes None, so L62 fails...:(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.