[Webkit-unassigned] [Bug 68213] New: remove redundant and error-prone semantics with m_dirtyRect and m_contentsDirty in LayerChromium.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 15 19:36:48 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=68213

           Summary: remove redundant and error-prone semantics with
                    m_dirtyRect and m_contentsDirty in LayerChromium.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: shawnsingh at chromium.org


m_contentsDirty is used by some layers,  m_dirtyRect.isEmpty() is used by other layers.

Thankfully, LayerChromium initializes both properly, but the individual layer types may be expected to reset these values themselves, and they only set one or the other, not both.


One solution is to remove m_contentsDirty.  All layers should check if the m_dirtyRect is empty.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list