[Webkit-unassigned] [Bug 68207] Minor cleanups related to LayerChromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68207





--- Comment #3 from James Robinson <jamesr at chromium.org>  2011-09-15 19:02:42 PST ---
(From update of attachment 107584)
View in context: https://bugs.webkit.org/attachment.cgi?id=107584&action=review

I really wish you had done this as separate patches.  In fact, It'd be great if you could break it up - most of the changes look completely non-controversial and obvious, but because it's all one big patch I have to sit down and think carefully about all the changes instead of just approving most of them individually :(.  I'll look at this later when I get a chance.

> Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:284
>      m_dirtyRect.setLocation(FloatPoint());
>      m_dirtyRect.setSize(bounds());
> -    m_contentsDirty = true;
>      setNeedsCommit();

i'm a little wary of this for 0x0 layers

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.