[Webkit-unassigned] [Bug 68207] New: Minor cleanups related to LayerChromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68207

           Summary: Minor cleanups related to LayerChromium
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: shawnsingh at chromium.org
                CC: jamesr at chromium.org, nduca at chromium.org


While studying LayerChromium to make unit tests, I came across several points that should be cleaned up.

1. fix const correctness of preserves3D and replicaLayer accessors

2. remove default NULL argument in the LayerChromium::create function.  All existing instances of LayerChromium give an instance of the delegate, and it seems error prone to keep this default arg.

3.  re-name border functions to reflect that they are only for debug use

4. remove m_contentsDirty from LayerChromium, which had redundant and error-prone semantics with m_dirtyRect.  In particular, layers were using m_contentsDirty or m_dirtyRect, but not both.

5. NOT included in this first patch:  is it OK if we re-name isRootLayer to isNonCompositedContent ?   The only place the "isRootLayer" flag is being set is in the NonCompositedContentHost.  it seems appropriate to call it isNonCompositedContent() because (1) we gradually move away from having 3 different "root" layers (2) the notion of a root layer becomes more homogeneous with other layers


Please let me know what you think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.