[Webkit-unassigned] [Bug 68156] HTML5 <time> initial implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 15 17:50:08 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=68156





--- Comment #6 from Kent Tamura <tkent at chromium.org>  2011-09-15 17:50:08 PST ---
(From update of attachment 107484)
View in context: https://bugs.webkit.org/attachment.cgi?id=107484&action=review

> Source/WebCore/html/HTMLTimeElement.cpp:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

Why does this have Apple copyright?

> Source/WebCore/html/HTMLTimeElement.cpp:58
> +        // <TO_DO> set a bool var and notify the nearest artical element @ this date.

Why do we need to notify?

> Source/WebCore/html/HTMLTimeElement.cpp:86
> +    if (m_dateComponents.type())

Should compare with DateComponents::Invalid.

> Source/WebCore/html/HTMLTimeElement.cpp:88
> +    return 0;

You must not return 0. The specification says we must return null Date in this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list