[Webkit-unassigned] [Bug 68192] Add method to scroll current node to specific position in Chromium WebKit API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68192


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107552|review?                     |review-
               Flag|                            |




--- Comment #2 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-09-15 14:42:03 PST ---
(From update of attachment 107552)
View in context: https://bugs.webkit.org/attachment.cgi?id=107552&action=review

This logic seems to be in the wrong place. If you had it on Element, you could at least test it with window.internals.

> ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

No test?

> Source/WebKit/chromium/src/WebViewImpl.cpp:1834
> +        frame->view()->scrollBy(scrollOffset);

Missing indent.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.