[Webkit-unassigned] [Bug 68098] ValueAuto and ValueMediumDPI are the same for all platforms.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68098





--- Comment #6 from Konrad Piascik <kpiascik at yahoo.com>  2011-09-15 14:37:44 PST ---
(In reply to comment #5)
> (From update of attachment 107521 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107521&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Not all platforms should have the same default value for the
> > +        targetDensityDPI. Added an optional parameter to allow
> > +        platforms to override the default auto value.
> 
> The default value is set to 160 for a reason. The reason being that that is what the original iOS used. Android even went as far as specifying what they call -density independent pixels- DIPS, which are specified as pixels at 160 DPI.
> 
> Our devices (N9, N950) have a default DPI of 240 and we do not need this modification.
> 
> Changing to another default is just going to break all pages designed with 160 in mind (most mobile pages), so I do not see how this is going to help with anything. 
> 
> So so far I am not convinced this is the right thing to do.

Most mobile pages don't know or care about target density.  They code to a layout width, which is 320px for most sites.

In order for a device to display 320px at a density of 160DPI then that device must be at least 2 inches wide(screen width).  computeViewportAttributes will calculate a layout width smaller than 320px if a device's screen width is less than 2 inches.

This change allows each platform/device to specify its own default if needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.