[Webkit-unassigned] [Bug 68162] [chromium]The focus of an input field inside an Iframe doesn't get cleared even though clearFocusedNode is called.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68162


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107498|review?                     |review-
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2011-09-15 11:21:11 PST ---
(From update of attachment 107498)
View in context: https://bugs.webkit.org/attachment.cgi?id=107498&action=review

Thanks for the patch.  This change looks beneficial, there are just a couple process-oriented nits to clear up and then we'll be all set.

> Source/WebKit/chromium/src/WebViewImpl.cpp:1783
> +    // Get the focused frame.

This comment doesn't explain the "why" of any code, just the "what", which we can read on the next line anyway.  It's probably best to remove.

> Source/WebKit/chromium/ChangeLog:3
> +        Need a short description and bug URL (OOPS!)

Please fill out this information.  The Tools/Scripts/prepare-Changelog script can do that for you if you use the "-b" option.  Alternatively, "webkit-patch upload" can also help make this easier.

> Source/WebKit/chromium/ChangeLog:6
> +

It's a good idea to add some text to the ChangeLog explaining why you're making this change.  That helps folks reviewing your patch understand that problem you're solving and it helps other folks looking at this change in the future understand what you're accomplishing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.