[Webkit-unassigned] [Bug 68161] Web Inspector: Provide completions for object literals, arrays and functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68161


tonistiigi at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107497|                            |review?
               Flag|                            |




--- Comment #1 from tonistiigi at gmail.com  2011-09-15 08:09:17 PST ---
Created an attachment (id=107497)
 --> (https://bugs.webkit.org/attachment.cgi?id=107497&action=review)
Patch

Bit mixed feelings about adding this to the utils.rangeOfWord because it only makes sense on moving backwards. On the other hand, implementing the moving between textnodes again in a separate function wouldn't be good either.

There is also an edge case where expression could change the input value depending on the execution count. Then there would be possibility that expression is already run first when getting the completions. Other way would be to parse it so that all objects/function bodies remain empty {} and arrays empty []. Then we could at least get the completions for prototype properties. In my opinion while debugging it adds very much more if we get all completions for the actual object. I believe same kind of multi-execution also occures on watched expressions.

This should also fix a bug where previously "foo". provided completions but for example "foo{". didn't.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.