[Webkit-unassigned] [Bug 67594] :hover selector fails when hovering over a child select element with size attribute

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 15 06:41:32 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=67594





--- Comment #8 from Sameer Patil <mkrp87 at motorola.com>  2011-09-15 06:41:33 PST ---
(From update of attachment 106862)
View in context: https://bugs.webkit.org/attachment.cgi?id=106862&action=review

>> Source/WebCore/rendering/RenderLayer.cpp:3811
>> +    Node* newHoverNode = result.innerNode()->renderer() ? result.innerNode() : result.innerNonSharedNode();
> 
> This change is broad enough that I think we need more test cases than just the one with <select> and <option>.

Incorporated additional focusable elements test cases in test.

>> LayoutTests/ChangeLog:9
>> +        * fast/css/hover_affects_ancestor.html: Added.
> 
> This filename includes underscores. If you look at the other tests in this directory you’ll see they use dashes, not underscores.

done.

>> LayoutTests/fast/css/hover_affects_ancestor.html:2
>> +    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
> 
> This test is in a .html file bug is an .xhtml test. That most likely means the code is actually not parsed as XHTML at all. The test should either be changed to HTML (preferred) or put in a file with an XHTML extension.
> 
> You should just put an HTML5 doctype here. Or none at all.

done.

>> LayoutTests/fast/css/hover_affects_ancestor.html:29
>> +    its child element.</p>
> 
> I don’t see any code that “focuses” a child element.

I mean hovering elements contained by div container here in test, made changes in test case.

>> LayoutTests/fast/css/hover_affects_ancestor.html:51
>> +        eventSender.mouseMoveTo(143, 180);
> 
> Does this work cross-platform? It seems to me that the hardcoded coordinates are unlikely to be correct on all platforms.

Removed hardcoded values from test, now finding center point for element to send mouse hover.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list