[Webkit-unassigned] [Bug 67931] [GTK] Add WebKitWebContext to GTK API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67931





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-09-15 00:21:21 PST ---
(In reply to comment #2)
> (From update of attachment 107042 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107042&action=review
> 
> Looks good, but I have a few nits and a small request to fix some of the FIXMEs now that we are touching this code. I feel that if we don't fix them now, they'll never get fixed.

This bug is about the WebKit2 API, those FIXMEs are new features that could be impemented for both WebKit1 and WebKit2 and don't depend on the API. So we can file separate bug reports for them so that we don't forget it.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:96
> > + * WEBKIT_CACHE_MODEL_WEB_BROWSER.
> 
> Default value -> The default value

Done.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:134
> > +WebKitCacheModel
> > +webkit_web_context_get_cache_model(WebKitWebContext* context)
> 
> Extra newline here.

Done.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.h:87
> > +WK_EXPORT GType
> > +webkit_web_context_get_type        (void);
> > +
> > +WK_EXPORT WebKitWebContext *
> > +webkit_web_context_get_default     (void);
> > +
> > +WK_EXPORT void
> > +webkit_web_context_set_cache_model (WebKitWebContext *context,
> > +                                    WebKitCacheModel  cache_model);
> > +WK_EXPORT WebKitCacheModel
> > +webkit_web_context_get_cache_model (WebKitWebContext *context);
> > +
> 
> Do you think it makes sense to stop lining the arguments up between functions? It's really annoyng when you finally add a longer function and have to realign the entire file.

I like it, but I guess it's actually a matter of taste. 

> > Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp:48
> > +    // FIXME: Add disk cache handling when soup has the API
> > +    unsigned long urlCacheMemoryCapacity = 0;
> > +    unsigned long urlCacheDiskCapacity = 0;
> > +    uint64_t diskFreeSize = 0;
> 
> Soup has the API now, but I'm not sure if it's public yet.

It's marked as LIBSOUP_USE_UNSTABLE_REQUEST_API, but we are currently used auth dialog feature too which is also considered unstable, I think.

> > Source/WebKit2/WebProcess/gtk/WebProcessGtk.cpp:52
> > +    // FIXME: The Mac port calculates these values based on the amount of physical memory that's
> > +    // installed on the system. Currently these values match the Mac port for users with more than
> > +    // 512 MB and less than 1024 MB of physical memory.
> 
> Is it possible to do this now, at least for Linux?

I don't know, I'll look at it, but I'm more worried about the API in this moment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.