[Webkit-unassigned] [Bug 67883] Move root layer creation semantics to the outside of chromium compositor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67883





--- Comment #15 from Antoine Labour <piman at chromium.org>  2011-09-14 18:16:28 PST ---
(In reply to comment #13)
> (From update of attachment 107429 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107429&action=review
> 
> R=me with a few nits.
> 
> > Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.h:42
> > +class LayerChromium;
> 
> I don't think you need this fwd decl

Done.

> 
> > Source/WebCore/platform/graphics/chromium/NonCompositedContentHost.h:72
> > +    WebCore::IntSize m_viewportSize;
> 
> Just IntSize, we're in the WebCore namespace here.

Done.

> 
> > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:411
> > +    for (int surfaceIndex = m_updateList.size() - 1; surfaceIndex >= 0 ; --surfaceIndex) {
> 
> nit: I don't think iteration order matters here, so I'd just loop through in the normal order [0, m_updateList.size()). Makes it a bit easier to spot check that this is supposed to hit every entry in the list.

Done (busted for copy&paste).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.