[Webkit-unassigned] [Bug 67952] Ask for audio hardware buffer size instead of using hardwired constants.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67952


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107400|review?                     |review+
               Flag|                            |




--- Comment #15 from Kenneth Russell <kbr at google.com>  2011-09-14 16:49:31 PST ---
(From update of attachment 107400)
View in context: https://bugs.webkit.org/attachment.cgi?id=107400&action=review

This looks fine overall, but it has to wait to land until the downstream Chromium code implementing the new entry point has been checked in. At that point, Source/WebKit/chromium/DEPS will presumably need to be rolled forward. If so, then I'd suggest incorporating that roll into this patch so the dependencies are clearer.

> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:72
> +    ASSERT(m_callbackBufferSize <= maximumCallbackBufferSize);

Is asserting really the best behavior in this case, rather than for example clamping to the maximum callback buffer size?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.