[Webkit-unassigned] [Bug 66994] Implement Error.stack

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66994


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107215|review?                     |review-
               Flag|                            |




--- Comment #21 from Oliver Hunt <oliver at apple.com>  2011-09-14 15:10:58 PST ---
(From update of attachment 107215)
View in context: https://bugs.webkit.org/attachment.cgi?id=107215&action=review

r- due to the problem with printStack, but that's it.

> LayoutTests/fast/js/stack-trace-expected.txt:9
> +    0   normalInner at file:///Users/jmont/webkit/OpenSource/LayoutTests/fast/js/script-tests/stack-trace.js:21
> +    1   normalOuter at file:///Users/jmont/webkit/OpenSource/LayoutTests/fast/js/script-tests/stack-trace.js:20
> +    2   at file:///Users/jmont/webkit/OpenSource/LayoutTests/fast/js/script-tests/stack-trace.js:26

These will lead to sadness

> LayoutTests/fast/js/script-tests/stack-trace.js:9
> +		debug("    " + i + "   " + stackTrace[level]);

I think you want to do stackTrace[level].replace(location, "") here to make these tests happier

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.