[Webkit-unassigned] [Bug 68116] Tiered compilation heuristics do not account for value profile fullness

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68116


Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107399|review?                     |review+
               Flag|                            |




--- Comment #6 from Oliver Hunt <oliver at apple.com>  2011-09-14 15:07:34 PST ---
(From update of attachment 107399)
View in context: https://bugs.webkit.org/attachment.cgi?id=107399&action=review

Correct the printf bit before landing.

Would be nice to avoid unnecessary renames (buckets->m_buckets, etc) in future, as they add noise to the patch.

> Source/JavaScriptCore/jit/JITStubs.cpp:1840
> +        if (error)
> +            fprintf(stderr, "WARNING: optimized compilation from loop failed.\n");

Should be in a VERBOSE_OSR block?

Future patch might want to define a OSR_LOG() macro which might be nicer in the long run

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.