[Webkit-unassigned] [Bug 67750] Create a delegate class to help cleanly isolate the chromium compositor API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67750


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107377|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #12 from James Robinson <jamesr at chromium.org>  2011-09-14 13:05:02 PST ---
(From update of attachment 107377)
View in context: https://bugs.webkit.org/attachment.cgi?id=107377&action=review

Looks good.  Left one comment FYI but this is fine to land as-is

> Source/WebCore/platform/graphics/chromium/LayerChromium.h:60
> +    virtual ~CCLayerDelegate() { }

another thing: we normally put the d'tor in the protected section, since it rarely makes sense to delete a delegate through a CCLayerDelegate*

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.