[Webkit-unassigned] [Bug 57694] StorageAreaSync::sync needs a transaction for the performance.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57694


Gustavo Sverzut Barbieri <barbieri at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barbieri at profusion.mobi




--- Comment #5 from Gustavo Sverzut Barbieri <barbieri at profusion.mobi>  2011-09-14 10:45:54 PST ---
informal r+ here.

Brady, actually it was an explanation problem, not patch problem. At least points you listed are connected:

"SQLite operations outside a transaction are all atomic and thus writes will block on I/O, which makes the process slow during heavy I/O"

The third point, explains why a test is not needed: this would only be exercised during premature process death, if it dies before transaction is committed to disk, nothing is actually saved. This is actually BETTER for consistency, as the database will only contain consistent data and not partially inserted values.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.