[Webkit-unassigned] [Bug 65025] Eliminate WebKit2 compilation warnings.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65025


Wajahat Siddiqui <mdwajahatali.siddiqui at motorola.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mdwajahatali.siddiqui at motor
                   |                            |ola.com




--- Comment #12 from Wajahat Siddiqui <mdwajahatali.siddiqui at motorola.com>  2011-09-14 07:12:20 PST ---
(In reply to comment #5)
Thanks for the review !!

> (From update of attachment 107168 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107168&action=review
> 
> > Source/WebKit2/UIProcess/WebContext.cpp:324
> > +        String sampleLogFilePath = String::format("WebProcess%llu", static_cast<long long unsigned int>(now));
> 
> The name we use for this type in WebKit is "unsigned long long" rather than "long long unsigned int". Anders may have additional comments. I know he often uses uint64_t intentionally so we might instead want to use the string that lets us format a uint64_t instead of changing the typecast.

Based on below comments its better to ignore fixing this for now as i see a need to capture full date + time and not floating values of time. Since fixing this will involve changing string format will submit as separate patch.
Hence reverting the changes :) 

> 
> > Source/WebKit2/UIProcess/WebContext.cpp:733
> > +    String sampleLogFilePath = String::format("WebProcess%llu", static_cast<long long unsigned int>(now));
> 
> Ditto.

Same as above

> 
> > Source/WebKit2/ChangeLog:3
> > +        Eliminate WebKit2 compilation warnings.
> 
> It would be better if this said what compiler and platform these warnings were found with.

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.