[Webkit-unassigned] [Bug 67952] Ask for audio hardware buffer size instead of using hardwired constants.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 13 20:48:29 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #107216|review?                     |review-
               Flag|                            |

--- Comment #10 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-09-13 20:48:29 PST ---
(From update of attachment 107216)
View in context: https://bugs.webkit.org/attachment.cgi?id=107216&action=review

> Source/WebKit/chromium/public/WebKitPlatformSupport.h:310
>      virtual double audioHardwareSampleRate() { return 0; }

It seems like we are growing enough audio specific functions here to perhaps
justify defining a WebAudioSupport interface.  This is a larger refactoring
though, and it doesn't have to be a pre-requisite for this patch.

> Source/WebKit/chromium/src/AudioDestinationChromium.cpp:66
> +    m_callbackBufferSize = webKitPlatformSupport()->audioHardwareBufferSize();

nit: I think it is a bit awkward to use this member variable to store the audioHardwareBufferSize result.  It seems like it would be better to create a local variable for this.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list