[Webkit-unassigned] [Bug 67750] Create a delegate class to help cleanly isolate the chromium compositor API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 13 18:24:30 PDT 2011


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
 Attachment #107198|review?                     |review+
               Flag|                            |

--- Comment #10 from James Robinson <jamesr at chromium.org>  2011-09-13 18:24:30 PST ---
(From update of attachment 107198)
View in context: https://bugs.webkit.org/attachment.cgi?id=107198&action=review


> Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h:48
> +    static PassRefPtr<ContentLayerChromium> create(CCLayerDelegate* = 0);

nit: we're inconsistent in the various *LayerChromium::create() calls about whether there's a default param. I don't think a null delegate makes sense for this layer type so probably better to remove it.

> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:56
> +#include "RenderLayerBacking.h"

i don't think you need this #include any more, and it's actually a layering violation (things in WebCore/platform should not depend on anything in WebCore/ outside of WebCore/platform)

> Source/WebCore/platform/graphics/chromium/ImageLayerChromium.h:52
> +    static PassRefPtr<ImageLayerChromium> create(CCLayerDelegate* = 0);

nit: no default 0

> Source/WebCore/platform/graphics/chromium/ImageLayerChromium.h:61
> +    ImageLayerChromium(CCLayerDelegate*);

nit: explicit

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list