[Webkit-unassigned] [Bug 62842] [EFL] Change behavior of ewk_view_zoom_get/set to call Frame::scalePage.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62842





--- Comment #8 from Ryuan Choi <ryuan.choi at samsung.com>  2011-09-13 17:25:07 PST ---
(In reply to comment #5)
> Let's come back to this one at last.
> 
> Having API in ewk_view and ewk_frame with the same name but with different behavior does not sound very sensible to me -- either we make all the calls perform the same type of zoom/scaling, or we change the API to avoid confusions.
> 

Sorry for late answer.

If then, how do you think about removing ewk_view_zoom_set/get and adding ewk_view_scale_set/get?

> As as mentioned before, it'd be good to verify if the math in the patch is also right: all those multiplications were there so that the the page was kept pretty much at the same point after zooming. Does that still happen?

Yes, at least, there are no issues related to position.

(In reply to comment #7)
> (From update of attachment 97542 [details])
> I am agreeing with Eric here, this code is pretty hard to read and not so WebKit'ish. I understand that you want your public API to be in C, but isn't it possible to at least have all the private implementations written in C++? And I am also pretty sure that you should be able to replace EINA_FALSE with false without any issues.

I tried to keep EFL style for EFL specific files although WebKit style is clear for me.
I'll prepare patch like you and eric mentioned.

Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.