[Webkit-unassigned] [Bug 67985] SpeculativeJIT::shouldSpeculateInteger(NodeIndex, NodeIndex) should return false if either node can be double

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67985


Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107234|review?                     |review+
               Flag|                            |




--- Comment #10 from Geoffrey Garen <ggaren at apple.com>  2011-09-13 17:01:49 PST ---
(From update of attachment 107234)
View in context: https://bugs.webkit.org/attachment.cgi?id=107234&action=review

r=me but please remove stray printfs.

> Source/JavaScriptCore/ChangeLog:9
> +        This is a 17% speed-up on 3b-cube.

Typo: "3b".

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:390
> +            printf("%d is a double constant.\n", nodeIndex);

Stray printf.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:400
> +            printf("%d produces a double.\n", nodeIndex);

And here.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:405
> +            printf("%d has a double prediction.\n", nodeIndex);

And here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.