[Webkit-unassigned] [Bug 36683] For compatibility, execCommand should support deprecated 'useCSS' alias for 'styleWithCSS'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36683


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107237|commit-queue?               |commit-queue+
               Flag|                            |




--- Comment #35 from Darin Adler <darin at apple.com>  2011-09-13 15:09:18 PST ---
(From update of attachment 107237)
View in context: https://bugs.webkit.org/attachment.cgi?id=107237&action=review

> LayoutTests/editing/execCommand/use-css.html:42
> +testUseCSS(false, true);
> +testUseCSS('false', true);
> +testUseCSS('FALSE', true);
> +testUseCSS(true, false);
> +testUseCSS('random string', false);

Other cases to test would be the empty string and the string " false " (which apparently means true).

> LayoutTests/editing/execCommand/use-css.html:47
> +if (document.queryCommandState('useCSS') === false)
> +    testPassed("queryCommandState('useCSS') returns false");
> +else
> +    testFailed("queryCommandState('useCSS') should return boolean false");

I think the shouldBe macro does a better job of this; I’m not sure that === false will fail for every value other than false.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.