[Webkit-unassigned] [Bug 67985] SpeculativeJIT::shouldSpeculateInteger(NodeIndex, NodeIndex) should return false if either node can be double

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67985


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #8 from Darin Adler <darin at apple.com>  2011-09-13 14:45:56 PST ---
(In reply to comment #6)
> > Source/JavaScriptCore/ChangeLog:38
> > +        * dfg/DFGGenerationInfo.h:
> > +        (JSC::DFG::isJSFormat):
> > +        (JSC::DFG::isJSInteger):
> > +        (JSC::DFG::isJSDouble):
> > +        (JSC::DFG::isJSCell):
> > +        (JSC::DFG::isJSBoolean):
> > +        (JSC::DFG::GenerationInfo::isJSFormat):
> > +        (JSC::DFG::GenerationInfo::isJSInteger):
> > +        (JSC::DFG::GenerationInfo::isJSDouble):
> > +        (JSC::DFG::GenerationInfo::isJSCell):
> > +        (JSC::DFG::GenerationInfo::isJSBoolean):
> > +        * dfg/DFGJITCodeGenerator.cpp:
> > +        (JSC::DFG::JITCodeGenerator::isKnownInteger):
> > +        (JSC::DFG::JITCodeGenerator::isKnownNumeric):
> > +        (JSC::DFG::JITCodeGenerator::isKnownCell):
> > +        (JSC::DFG::JITCodeGenerator::isKnownNotInteger):
> > +        (JSC::DFG::JITCodeGenerator::isKnownBoolean):
> > +        * dfg/DFGJITCodeGenerator.h:
> > +        * dfg/DFGNonSpeculativeJIT.cpp:
> > +        (JSC::DFG::NonSpeculativeJIT::compile):
> > +        * dfg/DFGSpeculativeJIT.h:
> > +        (JSC::DFG::SpeculativeJIT::isInteger):
> > +        (JSC::DFG::SpeculativeJIT::shouldSpeculateDouble):
> > +        (JSC::DFG::SpeculativeJIT::shouldNotSpeculateInteger):
> > +        (JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
> 
> It's great to put line-by-line comments next to this auto-generated helper text, but in cases where you don't do that, I think it's better just to delete the text.

I’m not sure I agree. Some people like to be able to search for modified functions by deleting the change log. Lets not belabor the point in this patch, but might want to talk to others, perhaps including Maciej, about this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.