[Webkit-unassigned] [Bug 36683] For compatibility, execCommand should support deprecated 'useCSS' alias for 'styleWithCSS'

Tue Sep 13 12:57:46 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=36683

--- Comment #26 from Kiyoto Tamura <owenestea at gmail.com>  2011-09-13 12:57:45 PST ---
> Let's add tests for queryCommandState/queryCommandValue and then land this patch.

Just for 'useCSS' or also for 'styleWithCSS'?

(In reply to comment #25)
> (From update of attachment 107131 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107131&action=review
> 
> Let's add tests for queryCommandState/queryCommandValue and then land this patch.
> 
> > LayoutTests/editing/execCommand/style-with-css.html:1
> > +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
> 
> Can we use new style? (i.e. <!DOCTYPE html>)
> 
> > LayoutTests/editing/execCommand/style-with-css.html:21
> > +    {
> > +        testPassed('styleWithCSS changed the state successfully');
> > +    } else {
> > +        testFailed('styleWithCSS failed with the argument ' + styleArg);
> > +    }
> 
> No curly brackets around single line statements.
> 
> > LayoutTests/editing/execCommand/use-css.html:1
> > +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
> 
> Ditto.
> 
> > LayoutTests/editing/execCommand/use-css.html:25
> > +    {
> > +        testPassed('useCSS changed the state successfully');
> > +    } else {
> > +        testFailed('useCSS failed with the argument ' + styleArg);
> > +    }
> 
> Ditto.
> 
> > LayoutTests/editing/execCommand/use-css.html:38
> > +    if (testContainer.innerHTML === expectedContents) {
> > +        testPassed("one " + toggleCommand + " command converted " + initialContents + " to " + expectedContents);
> > +    } else {
> > +        testFailed("one " + toggleCommand + " command converted " + initialContents + " to " + testContainer.innerHTML + ", expected " + expectedContents);
> > +    }
> 
> Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.