[Webkit-unassigned] [Bug 61541] Port W3C audio and video tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61541





--- Comment #3 from Eric Carlson <eric.carlson at apple.com>  2011-09-13 10:41:46 PST ---
(From update of attachment 94993)
View in context: https://bugs.webkit.org/attachment.cgi?id=94993&action=review

Thanks, this is fantastic! 

> LayoutTests/media/W3C/w3cwrapper.js:52
> +function async_test(title, options) {
> +  description(title);
> +  if (window.layoutTestController) {
> +    layoutTestController.dumpAsText();
> +    layoutTestController.waitUntilDone();
> +  }
> +  var t = {
> +    step: function(testFunction) {
> +      try {
> +        testFunction();
> +      }
> +      catch (e) {
> +        testFailed('Aborted with exception: ' + e.message);
> +      }
> +    },
> +
> +    done: function() {
> +      debug('<br /><span class="pass">TEST COMPLETE</span>');
> +      if (window.layoutTestController) {
> +        layoutTestController.notifyDone();
> +      }
> +    }
> +  }
> +
> +  return t;
> +}

I see that the "options" parameter is ignored. It looks like 'timeout' is currently the only parameter, which I assume we can ignore because of DRT's own timeout, but it is probably worth adding a comment to that effect and throwing an exception if any other option is passed in case future tests add other options.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.