[Webkit-unassigned] [Bug 65025] Eliminate WebKit2 compilation warnings.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65025





--- Comment #9 from Darin Adler <darin at apple.com>  2011-09-13 10:26:07 PST ---
(In reply to comment #8)
> (In reply to comment #5)
> > (From update of attachment 107168 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=107168&action=review
> > 
> > > Source/WebKit2/UIProcess/WebContext.cpp:324
> > > +        String sampleLogFilePath = String::format("WebProcess%llu", static_cast<long long unsigned int>(now));
> > 
> > The name we use for this type in WebKit is "unsigned long long" rather than "long long unsigned int". Anders may have additional comments. I know he often uses uint64_t intentionally so we might instead want to use the string that lets us format a uint64_t instead of changing the typecast.
> 
> We only use explicitly sized types when dealing with CoreIPC messages; you want to avoid sending an unsigned long between a 64-bit and a 32-bit process.

Sure, but this is about interoperating with printf format strings. The two ways to do that are to use the macros for creating the format strings, or casting to a built-in language type such as "unsigned long long". Do you have a comment on which is preferred? Maybe the right fix is to use a format string more like "%.0f" instead of trying to cast to an integral type?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.