[Webkit-unassigned] [Bug 65025] Eliminate WebKit2 compilation warnings.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 13 10:00:23 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=65025





--- Comment #8 from Anders Carlsson <andersca at apple.com>  2011-09-13 10:00:22 PST ---
(In reply to comment #5)
> (From update of attachment 107168 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107168&action=review
> 
> > Source/WebKit2/UIProcess/WebContext.cpp:324
> > +        String sampleLogFilePath = String::format("WebProcess%llu", static_cast<long long unsigned int>(now));
> 
> The name we use for this type in WebKit is "unsigned long long" rather than "long long unsigned int". Anders may have additional comments. I know he often uses uint64_t intentionally so we might instead want to use the string that lets us format a uint64_t instead of changing the typecast.

We only use explicitly sized types when dealing with CoreIPC messages; you want to avoid sending an unsigned long between a 64-bit and a 32-bit process.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list