[Webkit-unassigned] [Bug 67985] SpeculativeJIT::shouldSpeculateInteger(NodeIndex, NodeIndex) should return false if either node can be double

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67985


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107146|review?                     |review+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2011-09-13 09:53:07 PST ---
(From update of attachment 107146)
View in context: https://bugs.webkit.org/attachment.cgi?id=107146&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:385
> +    bool shouldNotSpeculateInteger(NodeIndex nodeIndex)

I think the function would be clearer with a small “why” comment in it.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:392
> +        if ((info.registerFormat() | DataFormatJS) == DataFormatJSDouble
> +            || (info.spillFormat() | DataFormatJS) == DataFormatJSDouble)

I think this would read better on a single line.

I think this would read better with a small inline helper function that does the (format | DataFormatJS) == DataFormatJSDouble ditty, with a pleasant name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.