[Webkit-unassigned] [Bug 65025] Eliminate WebKit2 compilation warnings.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65025


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107168|review?                     |review+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2011-09-13 09:49:12 PST ---
(From update of attachment 107168)
View in context: https://bugs.webkit.org/attachment.cgi?id=107168&action=review

> Source/WebKit2/UIProcess/WebContext.cpp:324
> +        String sampleLogFilePath = String::format("WebProcess%llu", static_cast<long long unsigned int>(now));

The name we use for this type in WebKit is "unsigned long long" rather than "long long unsigned int". Anders may have additional comments. I know he often uses uint64_t intentionally so we might instead want to use the string that lets us format a uint64_t instead of changing the typecast.

> Source/WebKit2/UIProcess/WebContext.cpp:733
> +    String sampleLogFilePath = String::format("WebProcess%llu", static_cast<long long unsigned int>(now));

Ditto.

> Source/WebKit2/ChangeLog:3
> +        Eliminate WebKit2 compilation warnings.

It would be better if this said what compiler and platform these warnings were found with.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.