[Webkit-unassigned] [Bug 66969] Chromium: Add a layer for rubber-band overhang painting to the hardware path.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66969


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106764|review?                     |review-
               Flag|                            |




--- Comment #49 from James Robinson <jamesr at chromium.org>  2011-09-13 09:44:18 PST ---
(From update of attachment 106764)
View in context: https://bugs.webkit.org/attachment.cgi?id=106764&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:960
> +        // Keep the overhang layer's size synchronized with the frame size.

This comment is useless, remove it

> Source/WebCore/rendering/RenderLayerCompositor.h:316
> +    OwnPtr<GraphicsLayer> m_layerForOverhangAreas;

shouldn't this be guarded by #if PLATFORM(CHROMIUM) along with the other logic? There's no need to add overhead for other ports that will never use this.

> LayoutTests/platform/chromium-gpu/compositing/rubberbanding/transform-overhang-e-expected.txt:1
> +layer at (0,0) size 800x600

you shouldn't need any of these since the render tree is not useful.  Please add the line "layoutTestController.dumpAsText(true)" to your tests

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.