[Webkit-unassigned] [Bug 20677] WebKit wraps between hyphen-minus and numeric characters

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20677





--- Comment #48 from Xianzhu Wang <wangxianzhu at chromium.org>  2011-09-12 21:42:05 PST ---
(From update of attachment 106301)
View in context: https://bugs.webkit.org/attachment.cgi?id=106301&action=review

>> Source/WebCore/rendering/break_lines.cpp:134
>> +            // while allow breaking in 'ABCD-1234' and '1234-5678'. <https://bugs.webkit.org/show_bug.cgi?id=20677>
> 
> I don’t think having the bug number here is a good idea. I see other bug URLs in this file, but there’s no need long-term to track the bug number of each bug we fixed.

Done.

>> LayoutTests/ChangeLog:12
>> +        * fast/text/line-breaks-after-hyphen-before-number.html: Added.
> 
> I can’t find this test case in the patch.

Sorry, my fault. Fixed.

>> LayoutTests/fast/text/line-breaks-after-hyphen-before-number-expected.txt:8
>> +Summary: PASS
> 
> This output is not clear at all. The test would be better if the output made it clearer what was being tested.

Re-designed the input/output.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.