[Webkit-unassigned] [Bug 63023] [chromium] Searching may cause a segmentation fault in WebPluginDocument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63023





--- Comment #14 from Eric Seidel <eric at webkit.org>  2011-09-12 15:45:02 PST ---
(From update of attachment 100045)
View in context: https://bugs.webkit.org/attachment.cgi?id=100045&action=review

> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:754
> +    // Search through all of the frames and check if any of them contain a WebPluginDocument.
> +    bool pluginRemoved = false;
> +    while (frame) {
> +        if (frame->document().isPluginDocument() && frame->document().to<WebPluginDocument>().plugin()) {
> +            frame->executeScript(WebScriptSource(WebString::fromUTF8("document.body.innerHTML='';")));
> +            if (!frame->document().to<WebPluginDocument>().plugin())
> +                pluginRemoved = true;
> +            break;
> +        }
> +        frame = frame->traverseNext(false);
> +    }
> +    result->set(pluginRemoved);

Although I'm very glad you added a test (even adding a method on layout test controller!) I'm not sure why this method is needed (can't we remove the plugin in some other way via JS?)  It also would make more sense to me if it took some sort of fram that it was supposed to remove the plugin from.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.