[Webkit-unassigned] [Bug 62357] Expose aria-labelledby as TitleUIElement?

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62357


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96685|review?                     |review-
               Flag|                            |




--- Comment #6 from Eric Seidel <eric at webkit.org>  2011-09-12 15:35:44 PST ---
(From update of attachment 96685)
View in context: https://bugs.webkit.org/attachment.cgi?id=96685&action=review

This patch is clearly not ready for review.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

This will cause the CQ to fail.  You should either replace this with a list of affected tests, or explain why testing is impossible/impractical.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1356
> +//    const AtomicString& ariaLabelledBy = ariaLabeledByAttribute();
> +//    if (!ariaLabelledBy.isEmpty())
> +//        return ariaLabelledBy;

We don't commit commented out code.

> Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm:1032
> +    else if (m_object->isWebArea()) {
>          objectAttributes = webAreaAttrs;
> +    }

Style?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.