[Webkit-unassigned] [Bug 64297] [Qt][WK2] Add the Web Inspector to WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=64297


Jesus Sanchez-Palencia <jesus at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesus at webkit.org




--- Comment #88 from Jesus Sanchez-Palencia <jesus at webkit.org>  2011-09-12 14:40:35 PST ---
(In reply to comment #85 and #86)
I guess there is a general "urge" for discussing Qt API's for WK2. This is becoming more clear every day...


(In reply to comment #87)
> > > Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:53
> > > +namespace WebKit {
> > > +    class WebInspectorProxy;
> > > +}
> > 
> > We don't indent in namespaces.
> > 
>
>
>  1. no namespace brackets generates follow errors

I think here the reviewer meant that you shouldn't indent code inside the namespace scope and not that you should remove it (the brackets).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.