[Webkit-unassigned] [Bug 65530] ASSERT hit when frame flattening is on.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65530





--- Comment #3 from yi shen <yi.4.shen at nokia.com>  2011-09-12 12:44:00 PST ---
(In reply to comment #1)
> Created an attachment (id=107073)
 --> (https://bugs.webkit.org/attachment.cgi?id=107073&action=review) [details]
> proposal fix

In FrameView::layout(), when the frame flattening is on, and there is a parent view, it calls the parentView->layout() instead of doing the layout on current frameview. Ideally, calling the parentView->layout() eventually invokes the layout() on the current frameview.

However, there are two possibles that the current frameview won't get a chance to be layoutted. 1) The parentView's needsLayout() returns false when you call parentView->layout(); 2) The RenderIFrame::flattenFrame() returns false for some reasons, e.g. the size of the iframe is fixed. That's why the asset hits when loading some particular pages because the current frameview doesn't get layoutted.

The patch I made tries to fix this problem by checking the needsLayout() for current frameview when the recursive parent layout is done. If it still needs layout, then continue layouting the current frame as usual.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.