[Webkit-unassigned] [Bug 67883] Move root layer creation semantics to the outside of chromium compositor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 12 10:19:32 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=67883





--- Comment #5 from Adrienne Walker <enne at google.com>  2011-09-12 10:19:32 PST ---
(From update of attachment 106984)
View in context: https://bugs.webkit.org/attachment.cgi?id=106984&action=review

This is a minor nit, because I have an aversion to "you have to set X before class Y works" complexity; eventually somebody will violate that calling convention constraint so it's always better to just make that not be possible.

If the goal is to be able to mock out CCLayerTreeHost without needing a GraphicsLayer, an alternate solution would be to have NonCompositedContentHost::create() create the graphics layers and pass them to the constructor rather than having the constructor do it.  MockNonCompositedContentHost::create() could skip that step and pass null to its base class constructor.  You would still pass a NonCompositedContentHost to the CCLayerTreeHost::create function, so that you could pass a mock instead, but you wouldn't need to create and set all these layers just to construct a CCLayerTreeHost.

Just a suggestion of an alternate approach.  :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list