[Webkit-unassigned] [Bug 67192] API to set initial focus in gtk webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67192





--- Comment #22 from Martin Robinson <mrobinson at webkit.org>  2011-09-12 07:56:19 PST ---
(From update of attachment 107025)
View in context: https://bugs.webkit.org/attachment.cgi?id=107025&action=review

This looks good to me. Since it is an API change, it needs the approval of another reviewer. It'd also be nice if one of a11y people could chime in to say if this negatively affects caret navigation.

> Source/WebKit/gtk/tests/testwebview.c:399
> +    element = webkit_dom_html_document_get_active_element((WebKitDOMHTMLDocument*)document);

Here it would be good to use a GLib style cast if possible: WEBKIT_DOM_HTML_DOCUMENT(document).

> Source/WebKit/gtk/webkit/webkitwebview.cpp:4034
> + * Set the initial focus element for spatial(keyboard) navigation. So with spatial
> + * navigation when a page is loaded, user should be able see the initial position
> + * of focus without pressing tab/arrow key.
> + *

The English is a just a little off here. Maybe something like:

Set the initially focused element, so that the user can see the initial focus position withou pressing the tab or arrow key.

I removed the mention of spatial navigation because I assume this does the same thing whether or not it's enabled. Is that true?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.