[Webkit-unassigned] [Bug 67930] Implement flick gesture in Chromium Gesture Recognizer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67930





--- Comment #2 from Robert Kroeger <rjkroege at chromium.org>  2011-09-12 07:48:38 PST ---
(From update of attachment 107040)
View in context: https://bugs.webkit.org/attachment.cgi?id=107040&action=review

Good start. Please freshen.

> Source/WebCore/page/EventHandler.cpp:2213
> +        // FIXME: Stop flick if one is in progress.

This code is ultimately going to be dispatching events through what https://bugs.webkit.org/show_bug.cgi?id=67822 evolves into. In particular, implementing this FIXME requires dispatching the TapDownType to the target node/frame iff it has refcount > 1. (But if you wade through the review, you'll see that I have some work ahead on this.)

> Source/WebCore/page/EventHandler.cpp:2227
> +    case PlatformGestureEvent::FlickType:

no. we don't need another type.

We had decided that a flick starts on scroll end that has a velocity. You ought not to need a FlickType

> Source/WebCore/platform/PlatformGestureEvent.h:44
> +        FlickType,

no. (I said this before.)

> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:149
> +    gestures->append(PlatformGestureEvent(PlatformGestureEvent::FlickType, touchPoint.pos(), touchPoint.screenPos(), m_lastTouchTime, 0.f, 0.f, m_shiftKey, m_ctrlKey, m_altKey, m_metaKey));

no. See above.

> Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:223
> +        appendScrollGestureEnd(point, gestures);

remove appendFlickGesture, add ScrollEnd with velo.

> Source/WebCore/platform/chromium/PopupContainer.cpp:311
> +    case PlatformGestureEvent::FlickType:

Less new event types make your life easier.

> Source/WebKit/chromium/tests/InnerGestureRecognizerTest.cpp:472
> +{

More. Adjusted. With the traces for actual event sequences that I emailed out earlier.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.