[Webkit-unassigned] [Bug 67918] Crashes in WebCore::InsertListCommand::unlistifyParagraph

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67918


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107021|review?                     |review-
               Flag|                            |




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-11 22:50:52 PST ---
(From update of attachment 107021)
View in context: https://bugs.webkit.org/attachment.cgi?id=107021&action=review

> Source/WebCore/editing/htmlediting.cpp:669
> -        if (n->hasTagName(liTag) || isListElement(n->parentNode()))
> +        if (n->hasTagName(liTag) || (isListElement(n->parentNode()) && n->parentNode()->rendererIsEditable()))

This change seems wrong. You should be checking that n != root instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.