[Webkit-unassigned] [Bug 60430] selectstart is not fired when selection was created by arrow keys

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60430


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106853|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #17 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-11 22:14:41 PST ---
(From update of attachment 106853)
View in context: https://bugs.webkit.org/attachment.cgi?id=106853&action=review

> Source/WebCore/ChangeLog:1
> +2011-09-09  Arko Saha  <arko at motorola.com> and Kaustubh Atrawalkar  <kaustubh at motorola.com>

We don't normally list two authors like this. If you're like to live a credit, then please mention it in the description below (after/before "Fire selectstart when...").

> LayoutTests/fast/events/selectstart-by-arrow-keys-prevent-default.html:17
> +eventSender.keyDown("rightArrow", ["shiftKey"]);

Because this line will throw an exception outside of DRT, you should consider wrapping it in if and explain how you'd test manually on a browser.

> LayoutTests/fast/events/selectstart-by-arrow-keys.html:19
> +eventSender.keyDown("rightArrow");
> +logResult('Check (Right arrow)', 0);

Ditto about wrapping these in if and explaining how to test manually. If manual test is not possible, you can also say so to clarify.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.