[Webkit-unassigned] [Bug 36683] For compatibility, execCommand should support deprecated 'useCSS' alias for 'styleWithCSS'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36683





--- Comment #16 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-11 22:06:38 PST ---
(From update of attachment 107017)
View in context: https://bugs.webkit.org/attachment.cgi?id=107017&action=review

> Source/WebCore/ChangeLog:9
> +        the boolean false or the case-insensitive string "false". This is per http://aryeh.name/spec/editing/editing.html#the-stylewithcss-command

Nit: You should probably line break after "per".

> Source/WebCore/editing/EditorCommand.cpp:1027
> +    frame->editor()->setShouldStyleWithCSS(equalIgnoringCase(value, "false"));
>      return true;

Per Aryeh's spec, it might be a good idea to log a console message saying that this command is deprecated.

> Source/WebCore/editing/EditorCommand.cpp:1540
> +        { "UseCSS", { executeUseCSS, supported, enabled, stateStyleWithCSS, valueNull, notTextInsertion, doNotAllowExecutionWhenDisabled } },

Are you sure queryCommandState("useCSS") should behave like queryCommandState("styleWithCSS")?

> LayoutTests/editing/execCommand/style-with-css.html:10
> +<script src="script-tests/style-with-css.js"></script>

You can just include the script here instead.

> LayoutTests/editing/execCommand/use-css.html:10
> +<script src="script-tests/use-css.js"></script>

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.