[Webkit-unassigned] [Bug 36683] For compatibility, execCommand should support deprecated 'useCSS' alias for 'styleWithCSS'

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 10 23:14:16 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #107001|review?                     |review-
               Flag|                            |

--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-10 23:14:15 PST ---
(From update of attachment 107001)
View in context: https://bugs.webkit.org/attachment.cgi?id=107001&action=review

> Source/WebCore/ChangeLog:7
> +

Please explain what kind of change you're making here.  See other change log entries for examples.

> LayoutTests/ChangeLog:7
> +        Adding useCSS support for execCommand and changing the behavior of styleWithCSS in accordance
> +        to http://aryeh.name/spec/editing/editing.html#the-stylewithcss-command

This description should appear in the change log for WebCore.

> LayoutTests/ChangeLog:9
> +        Reviewed by NOBODY (OOPS!).

"Reviewed by" should appear before the description.

> LayoutTests/ChangeLog:13
> +        * editing/execCommand/script-tests/toggle-text-decorations.js:
> +        (testSingleToggle):
> +        * editing/execCommand/toggle-text-decorations-expected.txt:

I don't think modifying these tests is a good way to test this behavior change.  These tests are testing execCommand('underline'/'strikeThrough') behaviors, not styleWithCSS or useCSS.

If I were you, I would write a test that does:
1. queryCommandState('styleWithCSS') returns true/fase after calling execCommand('useCSS'...) with false/true
2. the result of execCommand('bold' or whatever command) contains span/b after calling execCommand('useCSS') with false/true

r- because of this.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list