[Webkit-unassigned] [Bug 67826] JavaScriptCore does not have speculative->baseline OSR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67826


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106988|0                           |1
        is obsolete|                            |
 Attachment #106988|review?                     |
               Flag|                            |
 Attachment #106992|                            |review?
               Flag|                            |




--- Comment #19 from Filip Pizlo <fpizlo at apple.com>  2011-09-10 17:50:38 PST ---
Created an attachment (id=106992)
 --> (https://bugs.webkit.org/attachment.cgi?id=106992&action=review)
the patch - fix broken assert

This now passes tests with tiering turned both on and off.  It's lucky that tiering turned off still leads to the OSR exit analysis running, since it revealed breakeage in an ASSERT statement for SetLocals.  It turns out that synthetic SetLocals (like the ones that initialize variables to undefined) are sufficiently special that the ASSERT about the bytecode index of the node following the SetLocal was wrong.  The ASSERT just needed to be made a slight bit more lenient.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.