[Webkit-unassigned] [Bug 51159] [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51159





--- Comment #14 from Jarred Nicholls <jarred at sencha.com>  2011-09-10 06:37:16 PST ---
(In reply to comment #12)
> (In reply to comment #8)
> > (From update of attachment 76727 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=76727&action=review
> > 
> > > WebCore/ChangeLog:10
> > > +        Permit any url with a local scheme to set a user style sheet. Allow qrc
> > > +        resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
> > > +
> > 
> > I think a less intrusive way to do this would be to convert the qrc URL to a file URL in QWebSetttings::setUserStyleSheerUrl().
> 
> Out of curiosity why not this way? 

How would you go from qrc => file?

> Seems odd to put a Qt'ism in KURL if there's an alternative in a Qt specific file.

To be fair, it's Qt's KURL, so it is Qt specific regardless...

If you meant qrc => base64 data url, then that would work though is less performant and qrc is already loaded in memory as it is.  Also, I think the smarter check in Page.cpp opens it up more for future "local" schemes, but it's a stretch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.