[Webkit-unassigned] [Bug 67864] [Qt] Win32 build broken due to MachineStackMarker.cpp/.o failing to link against pthreads library

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67864


Jarred Nicholls <jarred at sencha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #106966|                            |review?, commit-queue?
               Flag|                            |




--- Comment #2 from Jarred Nicholls <jarred at sencha.com>  2011-09-09 22:45:34 PST ---
Created an attachment (id=106966)
 --> (https://bugs.webkit.org/attachment.cgi?id=106966&action=review)
Fix build errors

Pretty sure Qt wouldn't attempt multi-threads on anything other than unix (not even OS X).  Attached is a patch that should fix the build.  

JSC is grossly pthread-dependent in the runtime and heap access in multi-thread-enabled blocks.  A huge improvement would need to be made so platforms can provide their own means of threading, e.g., Qt can use their own PlatformThread (QThread).

Based on what I'm seeing, the Win port uses pthread-win32 (http://sourceware.org/pthreads-win32/ and binaries here ftp://sourceware.org/pub/pthreads-win32/dll-latest/lib/) instead of the Win API threading functions in windows.h.  Qt Win32 is likely never going to rely on that, so we'll need to keep Qt Win32 out of the loop for now and maybe create a bug to enhance that using Qt threading, or some other reasonable work around.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.