[Webkit-unassigned] [Bug 67582] Calling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 9 18:21:53 PDT 2011


--- Comment #7 from Huajun.Li <huajun.li.lee at gmail.com>  2011-09-09 18:21:53 PST ---
(In reply to comment #6)
> > in that it just calls synchronousIconForPageURL and creates a platform-specific representation of the raw image (in ewk's case, a cairo_surface_t). We can't hold the m_urlAndIconLock mutex ourselves, and the rest of the call stack is inside WebCore.
> > 
> > Can you elaborate a little on your thoughts?
> Your comments point in the right direction. Remove the call to IconDatabase ::synchronousIconForPageURL and add a new method to converts to your platform specific representation while holding the lock. Then call this method instead.
> Does that make sense to you? (The current state of things appears to leave you open to race conditions which make cause misc crashes at random points in your code.)
> PS imo, this method seems flawed and perhaps we should just remove it in every platform, but for this bug ewk is the target :). I suspect the OS X platform may have similar issues because it calls webGetNSImage which does some complicated things. I'll look at this for other platforms and file some bugs.

I ever checked QT port, and found it may have same issue, so it is not specific to ewk. :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list